From 67ad5296da78fca540a313d92d3d1bf475a38184 Mon Sep 17 00:00:00 2001
From: Henrik Lepson <henrikk895@gmail.com>
Date: Mon, 4 Oct 2021 19:54:17 +0300
Subject: [PATCH 1/2] MOB-12 started working on new PIN1 view layout

---
 .../app/src/main/res/layout/fragment_pin.xml  | 46 ++++++++++++-------
 .../app/src/main/res/values/strings.xml       |  9 ++--
 2 files changed, 34 insertions(+), 21 deletions(-)

diff --git a/MobileAuthApp/app/src/main/res/layout/fragment_pin.xml b/MobileAuthApp/app/src/main/res/layout/fragment_pin.xml
index b8019fe..250b816 100644
--- a/MobileAuthApp/app/src/main/res/layout/fragment_pin.xml
+++ b/MobileAuthApp/app/src/main/res/layout/fragment_pin.xml
@@ -7,24 +7,36 @@
     android:padding="24dp"
     tools:context=".PinFragment">
 
-    <TextView
-        android:id="@+id/pin_fragment_text"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:text="@string/pin_fragment"
-        app:layout_constraintTop_toTopOf="parent"
-        app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintEnd_toEndOf="parent" />
-
-    <EditText
-        android:id="@+id/pin_edit_text"
+    <com.google.android.material.card.MaterialCardView
+        android:id="@+id/card_view"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:hint="@string/enter_pin"
-        android:inputType="numberPassword"
+        android:layout_margin="8dp"
+        app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toBottomOf="@id/pin_fragment_text"
-        app:layout_constraintEnd_toEndOf="parent"/>
+        app:layout_constraintTop_toTopOf="parent">
+
+        <LinearLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:orientation="vertical">
+
+            <TextView
+                android:id="@+id/pin_fragment_text"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:text="@string/pin_fragment" />
+
+            <EditText
+                android:id="@+id/pin_edit_text"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:hint="@string/enter_pin"
+                android:inputType="numberPassword" />
+
+        </LinearLayout>
+
+    </com.google.android.material.card.MaterialCardView>
 
     <Button
         android:id="@+id/next_button"
@@ -32,7 +44,7 @@
         android:layout_height="wrap_content"
         android:text="@string/next_text"
         android:layout_marginTop="24dp"
-        app:layout_constraintTop_toBottomOf="@id/pin_edit_text"
+        app:layout_constraintTop_toBottomOf="@id/card_view"
         app:layout_constraintStart_toEndOf="@id/cancel_button"
         app:layout_constraintEnd_toEndOf="parent"/>
 
@@ -42,7 +54,7 @@
         android:layout_height="wrap_content"
         android:text="@string/cancel_text"
         android:layout_marginTop="24dp"
-        app:layout_constraintTop_toBottomOf="@id/pin_edit_text"
+        app:layout_constraintTop_toBottomOf="@id/card_view"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toStartOf="@id/next_button"/>
 
diff --git a/MobileAuthApp/app/src/main/res/values/strings.xml b/MobileAuthApp/app/src/main/res/values/strings.xml
index 8bd3167..ac03c59 100644
--- a/MobileAuthApp/app/src/main/res/values/strings.xml
+++ b/MobileAuthApp/app/src/main/res/values/strings.xml
@@ -1,15 +1,16 @@
 <resources>
     <string name="app_name">Mobile Authenticator</string>
     <string name="home_fragment">This is home fragment</string>
-    <string name="pin_fragment">This is pin fragment</string>
-    <string name="can_fragment">This is can fragment</string>
 
     <string name="begin_text">ALUSTA</string>
     <string name="next_text">EDASI</string>
     <string name="cancel_text">KATKESTA</string>
-    <string name="enter_pin">Sisesta PIN</string>
 
-    <!-- string resource sfor CanFragment -->
+    <!-- string resources for PinFragment -->
+    <string name="pin_fragment">Palun sisesta PIN1</string>
+    <string name="enter_pin">PIN1</string>
+
+    <!-- string resources for CanFragment -->
     <string name="example_can">Näide. 123456</string>
     <string name="text_can">CAN</string>
     <string name="enter_can">Sisesta ID kaardi CAN (Card Access Number)</string>

From c4d7da07ad90692f5835b99d1b05b6d2405ac380 Mon Sep 17 00:00:00 2001
From: Henrik Lepson <henrikk895@gmail.com>
Date: Mon, 4 Oct 2021 20:07:45 +0300
Subject: [PATCH 2/2] MOB-12 PIN1 view layout changed + pin length check

---
 .../mobileauthapp/PinFragment.kt              | 15 +++++---
 .../app/src/main/res/layout/fragment_pin.xml  | 36 ++++++++++++++-----
 .../app/src/main/res/values/strings.xml       |  4 ++-
 3 files changed, 41 insertions(+), 14 deletions(-)

diff --git a/MobileAuthApp/app/src/main/java/com/tarkvaraprojekt/mobileauthapp/PinFragment.kt b/MobileAuthApp/app/src/main/java/com/tarkvaraprojekt/mobileauthapp/PinFragment.kt
index 99c9e21..ec3e69b 100644
--- a/MobileAuthApp/app/src/main/java/com/tarkvaraprojekt/mobileauthapp/PinFragment.kt
+++ b/MobileAuthApp/app/src/main/java/com/tarkvaraprojekt/mobileauthapp/PinFragment.kt
@@ -4,6 +4,7 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import android.widget.Toast
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.activityViewModels
 import androidx.navigation.fragment.findNavController
@@ -36,10 +37,16 @@ class PinFragment : Fragment() {
     }
 
     private fun goToNextFragment() {
-        viewModel.setUserPin(
-            binding!!.pinEditText.text.toString()
-        )
-        findNavController().navigate(R.id.action_pinFragment_to_canFragment)
+        val enteredPin1 = binding!!.pinEditText.editText?.text.toString()
+        if (enteredPin1.length in 4..12) {
+            viewModel.setUserPin(
+                binding!!.pinEditText.editText?.text.toString()
+            )
+            findNavController().navigate(R.id.action_pinFragment_to_canFragment)
+        } else {
+            Toast.makeText(requireContext(), getString(R.string.length_pin), Toast.LENGTH_SHORT)
+                .show()
+        }
     }
 
     private fun goToTheStart() {
diff --git a/MobileAuthApp/app/src/main/res/layout/fragment_pin.xml b/MobileAuthApp/app/src/main/res/layout/fragment_pin.xml
index 250b816..a2668b8 100644
--- a/MobileAuthApp/app/src/main/res/layout/fragment_pin.xml
+++ b/MobileAuthApp/app/src/main/res/layout/fragment_pin.xml
@@ -19,20 +19,38 @@
         <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:orientation="vertical">
+            android:orientation="vertical"
+            android:padding="20dp">
 
             <TextView
                 android:id="@+id/pin_fragment_text"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
+                android:layout_margin="6dp"
                 android:text="@string/pin_fragment" />
 
-            <EditText
+            <com.google.android.material.textfield.TextInputLayout
                 android:id="@+id/pin_edit_text"
+                style="@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
+                android:layout_margin="6dp"
                 android:hint="@string/enter_pin"
-                android:inputType="numberPassword" />
+                app:counterEnabled="true"
+                app:counterMaxLength="12"
+                app:endIconMode="password_toggle"
+                app:errorEnabled="true"
+                app:helperText="@string/example_pin"
+                app:helperTextEnabled="true"
+                app:startIconDrawable="@drawable/can_logo">
+
+                <com.google.android.material.textfield.TextInputEditText
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:inputType="numberPassword"
+                    android:textSize="14sp" />
+
+            </com.google.android.material.textfield.TextInputLayout>
 
         </LinearLayout>
 
@@ -42,20 +60,20 @@
         android:id="@+id/next_button"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="@string/next_text"
         android:layout_marginTop="24dp"
-        app:layout_constraintTop_toBottomOf="@id/card_view"
+        android:text="@string/next_text"
+        app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toEndOf="@id/cancel_button"
-        app:layout_constraintEnd_toEndOf="parent"/>
+        app:layout_constraintTop_toBottomOf="@id/card_view" />
 
     <Button
         android:id="@+id/cancel_button"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="@string/cancel_text"
         android:layout_marginTop="24dp"
-        app:layout_constraintTop_toBottomOf="@id/card_view"
+        android:text="@string/cancel_text"
+        app:layout_constraintEnd_toStartOf="@id/next_button"
         app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintEnd_toStartOf="@id/next_button"/>
+        app:layout_constraintTop_toBottomOf="@id/card_view" />
 
 </androidx.constraintlayout.widget.ConstraintLayout>
\ No newline at end of file
diff --git a/MobileAuthApp/app/src/main/res/values/strings.xml b/MobileAuthApp/app/src/main/res/values/strings.xml
index ac03c59..b82e7fe 100644
--- a/MobileAuthApp/app/src/main/res/values/strings.xml
+++ b/MobileAuthApp/app/src/main/res/values/strings.xml
@@ -1,6 +1,6 @@
 <resources>
     <string name="app_name">Mobile Authenticator</string>
-    <string name="home_fragment">This is home fragment</string>
+    <string name="home_fragment">Work in progress</string>
 
     <string name="begin_text">ALUSTA</string>
     <string name="next_text">EDASI</string>
@@ -9,6 +9,8 @@
     <!-- string resources for PinFragment -->
     <string name="pin_fragment">Palun sisesta PIN1</string>
     <string name="enter_pin">PIN1</string>
+    <string name="example_pin">Näide. 1234</string>
+    <string name="length_pin">PIN1 lubatud pikkus on 4-12</string>
 
     <!-- string resources for CanFragment -->
     <string name="example_can">Näide. 123456</string>