arti/Estonian-ID-card-mobile-authenticator-POC
1
0
Fork 0
mirror of https://github.com/TanelOrumaa/Estonian-ID-card-mobile-authenticator-POC.git synced 2024-11-22 13:51:00 +02:00
Code Packages Releases Wiki Activity

Updated Peer Review Response (markdown)

Henrik Lepson 2021-12-06 20:46:54 +02:00
parent dafccb3537
commit 5d27ed9629
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Peer-Review-Response.md

@ -15,11 +15,11 @@ The PIN 2 view exists in the project, but the signing feature has not been imple
* **UC6: biometric authentication**
This feature will not be implemented. It was a relatively low priority feature that we hoped to implement when we started with this project, but so far we have not had time to start implementing it. It may be implemented after the software project course has already ended.
* **UC7: application closes automatically**
This feature was implemented and tested at the time of the peer review. We are not sure why it didn't work for the peer review team.
This feature was implemented and tested at the time of the peer review. We are not sure why it didn't work for the peer review team (maybe there could be an issue that Android OS works differently for phones that are made by different manufacturers).
* **UC8: authenticating to a website**
The user is not asked for PIN 1 if it is saved because the application prioritizes the speed of the authentication process. Otherwise the saving feature would become pointless. The user is not required to save PIN 1 in order to use the application for authentication purposes because it is always possible to enter it manually as well without application saving it.
* **UC10: authenticating to an application**
Similarily to the UC7 there seems to be somekind of a misunderstanding here because the test mobile app is included in the project (TestMobileApp folder) and at the time of peer review it should have been possible to use it for authentication purposes. It is important to note that for it to work the backend must be running (as described in the TestMobileApp readme) and the TestMobileApp must have access to the internet as well.
Similarily to the UC7 there seems to be somekind of a misunderstanding here because the test mobile app is included in the project (TestMobileApp folder) and at the time of peer review it should have been possible to use it for authentication purposes. It is important to note that for it to work the backend must be running (as described in the TestMobileApp readme) and the TestMobileApp must have access to the internet as well.
* **UC11-UC12: giving a signature**
This feature has not been implemented as of yet.
* **USN8: google talkback support**