arti/Estonian-ID-card-mobile-authenticator-POC
1
0
Fork 0
mirror of https://github.com/TanelOrumaa/Estonian-ID-card-mobile-authenticator-POC.git synced 2024-11-22 13:51:00 +02:00
Code Packages Releases Wiki Activity

Updated Peer Review Response (markdown)

Henrik Lepson 2021-12-03 20:48:09 +02:00
parent 091eb78597
commit b028832cbc
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Peer-Review-Response.md

@ -1 +1,20 @@
# Peer Review Response
# Peer Review Response (not finished)
### Code Review
The unused code has been removed from the project. We changed the library for making HTTP POST requests at the last minute before the iteration 3 deadline, but we forgot to delete the classes that we had used with the previous library.
### Acceptance tests
* **UC3: PIN 2 view**
The PIN 2 view exists in the project, but this was unused as the signing feature had not yet been implemented.
* **UC6: biometric authentication**
This feature will not be implemented. It was a low priority feature that we hoped to implement when we started with this project, but it was not possible. It may be implemented after the course has ended.
* **UC7: application closes automatically**
This feature was implemented and tested at the time of the peer review. We are not sure why it didn't work for the peer review team.
* **UC8: authenticating to a website**
The user is not asked for PIN 1 if it saved because the application prioritizes the speed of the authentication process. Otherwise the saving feature would become pointless. The user is not required to save PIN 1 in order to use the application so it is always possible to enter it manually.
* **UC10: authenticating to an application**
Similarily to the UC7 there seems to be somekind of a misunderstanding here because the test mobile app is included in the project in the TestMobileApp folder and at the time of peer review it was possible to use it for authentication.
* **USN8: google talkback support**
This feature did not work and it will not be implemented as it was a low priority feature.