From 2c8cfbcea8e7286649840d7ec98d7e9d5e1d45a0 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Sat, 16 Dec 2017 01:09:41 +0100 Subject: [PATCH] Handle `setopt shwordsplit` (#89) This uses `emulate -L zsh` (as a more broad approach to `setopt localtoptions noshwordsplit`, or quoting things) in the entry points to zsh-autoenv. Fixes https://github.com/Tarrasch/zsh-autoenv/issues/75 --- autoenv.zsh | 4 +++- tests/ZDOTDIR.options/.zshenv | 1 + tests/_autoenv_utils.t | 4 ++++ tests/setup.zsh | 1 + tests/source-parent-until.t | 16 ++++++++++++++++ 5 files changed, 25 insertions(+), 1 deletion(-) diff --git a/autoenv.zsh b/autoenv.zsh index a7aaeb4..e70eec1 100644 --- a/autoenv.zsh +++ b/autoenv.zsh @@ -364,12 +364,13 @@ _autoenv_get_file_upwards() { if [[ $abs_parent_dir == $look_until ]]; then break fi - last=$parent_dir + last=$abs_parent_dir parent_dir="${parent_dir}/.." done } autoenv-edit() { + emulate -L zsh local env_file local -a files local -A check @@ -402,6 +403,7 @@ autoenv-edit() { } _autoenv_chpwd_handler() { + emulate -L zsh _autoenv_debug "Calling chpwd handler: PWD=$PWD" if (( $AUTOENV_DISABLED )); then diff --git a/tests/ZDOTDIR.options/.zshenv b/tests/ZDOTDIR.options/.zshenv index 61c751b..cacdc9b 100644 --- a/tests/ZDOTDIR.options/.zshenv +++ b/tests/ZDOTDIR.options/.zshenv @@ -1,2 +1,3 @@ # Set uncommon options that caused problems in the past. setopt noclobber +setopt shwordsplit diff --git a/tests/_autoenv_utils.t b/tests/_autoenv_utils.t index cd8b9ad..86e93c9 100644 --- a/tests/_autoenv_utils.t +++ b/tests/_autoenv_utils.t @@ -96,3 +96,7 @@ of _autoenv_get_file_mtime (via ZDOTDIR.invalid-module_path/). $ touch -t 201401010102 dir $ _autoenv_get_file_mtime dir 1388538120 + +Stops when last (absolute) path does not change anymore. + + $ _autoenv_get_file_upwards / doesnotexist nevermatches diff --git a/tests/setup.zsh b/tests/setup.zsh index 0bbdbaf..02f41b3 100644 --- a/tests/setup.zsh +++ b/tests/setup.zsh @@ -28,6 +28,7 @@ fi # Add file ($1), version ($2), and optional hash ($3) to authentication file. test_autoenv_add_to_env() { + emulate -L zsh [[ -d ${AUTOENV_AUTH_FILE:h} ]] || mkdir -p ${AUTOENV_AUTH_FILE:h} _autoenv_deauthorize $1 { diff --git a/tests/source-parent-until.t b/tests/source-parent-until.t index c02a312..a6700bb 100644 --- a/tests/source-parent-until.t +++ b/tests/source-parent-until.t @@ -90,3 +90,19 @@ Look up to "/" (default). autoenv_source_parent_from_sub3: ENTERED_sub: PWD:sub3 from:sub to:sub3 done_sub3 + +Handles dirs with spaces. + + $ mkdir "dir with space" + $ echo "echo entered \$PWD\n" >| "dir with space/.autoenv.zsh" + $ test_autoenv_add_to_env "dir with space/.autoenv.zsh" + $ cd "dir with space" + entered */dir with space (glob) + +Handles dirs with spaces outside any root (should not hang). + + $ cd $CRAMTMP || exit + LEFT_root: * (glob) + LEFT_sub: * (glob) + $ mkdir "dir with space" + $ cd "dir with space"