From 33e485b38e401b51b2cc896145e1b60b70d5f0bb Mon Sep 17 00:00:00 2001 From: Davide Depau Date: Fri, 6 Jun 2025 22:44:08 +0200 Subject: [PATCH] Optimize verifyImage buffer comparison --- .../main/java/eu/depau/etchdroid/service/WorkerService.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/eu/depau/etchdroid/service/WorkerService.kt b/app/src/main/java/eu/depau/etchdroid/service/WorkerService.kt index d94f509..2731506 100644 --- a/app/src/main/java/eu/depau/etchdroid/service/WorkerService.kt +++ b/app/src/main/java/eu/depau/etchdroid/service/WorkerService.kt @@ -698,7 +698,12 @@ object WorkerServiceFlowImpl { throw UsbCommunicationException(e) } - if (!fileBuffer.contentEquals(deviceBuffer)) { + val mismatch = if (read == fileBuffer.size) { + !fileBuffer.contentEquals(deviceBuffer) + } else { + !fileBuffer.copyOf(read).contentEquals(deviceBuffer.copyOf(read)) + } + if (mismatch) { Telemetry.captureMessage("Verification failed") if (Build.VERSION.SDK_INT > 999999) { // Prevent the compiler from optimizing out the buffers, for debugging