From b263ffa28dfc8a47c86de952386066044a54917a Mon Sep 17 00:00:00 2001 From: Davide Depau Date: Wed, 1 Jul 2026 20:38:11 +0200 Subject: [PATCH] fix: remove GRANT_READ_URI_PERMISSION intent flag According to Gemini it's causing the rare java.lang.SecurityException I see in the crash analytics and it's not necessary. --- app/src/main/java/eu/depau/etchdroid/Intents.kt | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app/src/main/java/eu/depau/etchdroid/Intents.kt b/app/src/main/java/eu/depau/etchdroid/Intents.kt index 7c1fc35..6f8061a 100644 --- a/app/src/main/java/eu/depau/etchdroid/Intents.kt +++ b/app/src/main/java/eu/depau/etchdroid/Intents.kt @@ -50,7 +50,6 @@ fun getConfirmOperationActivityIntent( ): Intent { return mkIntent(packageContext, cls).apply { data = sourceUri - addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) putExtra("sourceUri", sourceUri) putExtra("destDevice", destDevice) } @@ -68,7 +67,6 @@ fun getStartJobIntent( return mkIntent(packageContext, cls).apply { action = Intents.START_JOB data = sourceUri - addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) putExtra("sourceUri", sourceUri) putExtra("destDevice", destDevice) putExtra("jobId", jobId) @@ -89,7 +87,6 @@ fun getProgressUpdateIntent( cls: Class<*>? = null, ) = mkIntent(packageContext, cls).apply { action = Intents.JOB_PROGRESS - addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) putExtra("sourceUri", sourceUri) putExtra( "status", JobStatusInfo( @@ -110,7 +107,6 @@ fun getErrorIntent( cls: Class<*>? = null, ) = mkIntent(packageContext, cls).apply { action = Intents.ERROR - addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) putExtra("sourceUri", sourceUri) putExtra( "status", @@ -129,7 +125,6 @@ fun getFinishedIntent( cls: Class<*>? = null, ) = mkIntent(packageContext, cls).apply { action = Intents.FINISHED - addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) putExtra("sourceUri", sourceUri) putExtra("status", JobStatusInfo(sourceUri, destDevice, totalBytes, totalBytes, jobId = -1)) } @@ -139,7 +134,6 @@ fun Intent.getProgressActivityPendingIntent( ): PendingIntent = PendingIntent.getActivity(context, requestCode, this.apply { // Set data uri to propagate the permission if (data == null) data = safeParcelableExtra("sourceUri") - addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP) addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP)