A fixture imported into two test modules becomes two definitions with separate caches, so the session-scoped calibration write ran once per module -- about 70s wasted on CI. Re-export it from conftest instead.
95 lines
3.7 KiB
Python
95 lines
3.7 KiB
Python
import pytest
|
|
import traceback as _tb
|
|
from pathlib import Path
|
|
|
|
from etchdroid.config import Config
|
|
from etchdroid.utils import mark
|
|
|
|
# A failing e2e test is almost never a Python bug in the harness — it's the app not
|
|
# reaching the expected state. So for every test failure we drop the firehose
|
|
# pytest/pluggy/selenium traceback and instead show a concise message + the in-repo
|
|
# frames + the denoised app logcat, which is what's actually useful when triaging.
|
|
_CLEAN_REPORT = pytest.StashKey()
|
|
|
|
|
|
def _repo_frames(exc_tb) -> str:
|
|
"""The traceback entries that live in this repo (drops venv/pytest internals).
|
|
|
|
Their source lines carry the awaited xpath, so this is the "what was it waiting
|
|
for" context."""
|
|
out = []
|
|
for f in _tb.extract_tb(exc_tb):
|
|
if "/site-packages/" in f.filename or "/.venv/" in f.filename:
|
|
continue
|
|
if "appium-tests" not in f.filename:
|
|
continue
|
|
loc = f.filename.split("appium-tests/", 1)[-1]
|
|
out.append(f" {loc}:{f.lineno} in {f.name}\n {(f.line or '').strip()}")
|
|
return "\n".join(out) or " (no in-repo frames)"
|
|
|
|
|
|
def _exception_message(exc) -> str:
|
|
# Selenium's str() is multi-line and ends with a JS "at ..." stack; keep the
|
|
# meaningful lines (e.g. the NoSuchElementError reason) and drop the JS frames.
|
|
# Harmless for plain Python exceptions (single-line str).
|
|
lines = [
|
|
ln.strip()
|
|
for ln in str(exc).splitlines()
|
|
if ln.strip() and not ln.strip().startswith("at ") and ln.strip() not in ("Message:", "Stacktrace:")
|
|
]
|
|
return " ".join(lines).strip() or exc.__class__.__name__
|
|
|
|
|
|
def _denoised_logcat(name: str) -> str:
|
|
if not Config.LOGCAT_DIR:
|
|
return "(LOGCAT_DIR not configured; no logcat captured)"
|
|
path = Path(Config.LOGCAT_DIR) / f"{name}.app.denoised.log"
|
|
try:
|
|
text = path.read_text(errors="replace").strip()
|
|
except OSError as e:
|
|
# Denoising failed (or never ran) in the fixture — say so rather than dumping
|
|
# the raw, un-denoised log.
|
|
return f"(denoised logcat unavailable: {e})"
|
|
return text or "(denoised logcat is empty)"
|
|
|
|
|
|
# Test boundaries and outcomes, for annotating the CI screen recording afterwards. Both are
|
|
# no-ops unless VM_MARKERS_FILE is set; see utils.mark and scripts/annotate-recording.py.
|
|
def pytest_runtest_logstart(nodeid, location):
|
|
mark(nodeid.split("::")[-1], kind="test")
|
|
|
|
|
|
def pytest_runtest_logreport(report):
|
|
# Only the call phase: setup/teardown outcomes would double up on every test.
|
|
if report.when == "call":
|
|
mark(f"{report.outcome.upper()} {report.nodeid.split('::')[-1]}")
|
|
|
|
|
|
@pytest.hookimpl(wrapper=True)
|
|
def pytest_runtest_makereport(item, call):
|
|
report = yield
|
|
|
|
if report.when == "call" and report.failed and call.excinfo is not None:
|
|
report.longrepr = (
|
|
f"{call.excinfo.typename}: {_exception_message(call.excinfo.value)}\n\n"
|
|
f"{_repo_frames(call.excinfo.tb)}"
|
|
)
|
|
# The denoised logcat is written during teardown, so append it then.
|
|
item.stash[_CLEAN_REPORT] = report
|
|
elif report.when == "teardown":
|
|
clean = item.stash.get(_CLEAN_REPORT, None)
|
|
if clean is not None:
|
|
clean.longrepr = (
|
|
f"{clean.longrepr}\n\n"
|
|
f"===== denoised app logcat: {item.name} =====\n"
|
|
f"{_denoised_logcat(item.name)}"
|
|
)
|
|
|
|
return report
|
|
|
|
|
|
# Re-exported here so the session-scoped speed measurement really runs once per session:
|
|
# a fixture imported into two test modules becomes two definitions with separate caches,
|
|
# which made the calibration write run once per module.
|
|
from etchdroid.fixtures import usb_write_speed_mbps # noqa: E402,F401
|