[lldb/Interpreter] Discard ScriptedThreadPlan::GetStopDescription return value (#96985)
This patch changes `ScriptedThreadPlan::GetStopDescription` behavior by
discarding its return value since it is optional in the first place (the
user doesn't need to provide a return value in their implementation).
This patch also addresses the test failures in TestStepScripted
following 9a9ec22 and re-enables the tests that were XFAIL'd previously.
The issue here was that the `Stream*` that's passed to
`ThreadPlanPython::GetDescription` wasn't being passed by reference to
the python method so it was never updated to reflect how the python
method interacted with it.
This patch solves this issue by making a temporary `StreamSP` that will
be passed to the python method by reference, after what we will copy its
content to the caller `Stream` pointer argument.
---------
Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
This commit is contained in:
1 parent
bb83a3df25
commit
1130e923e2
9 files changed
+28
-32
No files matched your search
+2
-10
@@ -26,15 +26,6 @@ ScriptedPythonInterface::ScriptedPythonInterface(
|
||||
ScriptInterpreterPythonImpl &interpreter)
|
||||
: ScriptedInterface(), m_interpreter(interpreter) {}
|
||||
|
||||
template <>
|
||||
void ScriptedPythonInterface::ReverseTransform(
|
||||
lldb_private::Stream *&original_arg, python::PythonObject transformed_arg,
|
||||
Status &error) {
|
||||
Stream *s = ExtractValueFromPythonObject<Stream *>(transformed_arg, error);
|
||||
*original_arg = *s;
|
||||
original_arg->PutCString(static_cast<StreamString *>(s)->GetData());
|
||||
}
|
||||
|
||||
template <>
|
||||
StructuredData::ArraySP
|
||||
ScriptedPythonInterface::ExtractValueFromPythonObject<StructuredData::ArraySP>(
|
||||
@@ -74,7 +65,8 @@ Event *ScriptedPythonInterface::ExtractValueFromPythonObject<Event *>(
|
||||
}
|
||||
|
||||
template <>
|
||||
Stream *ScriptedPythonInterface::ExtractValueFromPythonObject<Stream *>(
|
||||
lldb::StreamSP
|
||||
ScriptedPythonInterface::ExtractValueFromPythonObject<lldb::StreamSP>(
|
||||
python::PythonObject &p, Status &error) {
|
||||
if (lldb::SBStream *sb_stream = reinterpret_cast<lldb::SBStream *>(
|
||||
python::LLDBSWIGPython_CastPyObjectToSBStream(p.get())))
|
||||
|
||||
Reference in new issue
Block a user