[lldb] Fix incorrect uses of logical operator in 'if' condition check (NFC) (#94779)
The condition checking for missing class name, interpreter dictionary, and script object incorrectly used logical AND (&&), which could never be true to enter the 'if' block. This commit uses separate if conditions for each class name, interpreter dictionary, and script object. Cought by cppcheck - lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h:89:11: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h:91:16: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] Fix #89195 --------- Co-authored-by: Shivam Gupta <shivma98.tkg@gmail.com>
This commit is contained in:
1 parent
f8006a5932
commit
2ba3fe7356
1 file changed
+9
-8
@@ -85,14 +85,15 @@ public:
|
||||
bool has_class_name = !class_name.empty();
|
||||
bool has_interpreter_dict =
|
||||
!(llvm::StringRef(m_interpreter.GetDictionaryName()).empty());
|
||||
if (!has_class_name && !has_interpreter_dict && !script_obj) {
|
||||
if (!has_class_name)
|
||||
return create_error("Missing script class name.");
|
||||
else if (!has_interpreter_dict)
|
||||
return create_error("Invalid script interpreter dictionary.");
|
||||
else
|
||||
return create_error("Missing scripting object.");
|
||||
}
|
||||
|
||||
if (!has_class_name)
|
||||
return create_error("Missing script class name.");
|
||||
|
||||
if (!has_interpreter_dict)
|
||||
return create_error("Invalid script interpreter dictionary.");
|
||||
|
||||
if (!script_obj)
|
||||
return create_error("Missing scripting object.");
|
||||
|
||||
Locker py_lock(&m_interpreter, Locker::AcquireLock | Locker::NoSTDIN,
|
||||
Locker::FreeLock);
|
||||
|
||||
Reference in new issue
Block a user