[lldb] A few small code modernizations and cleanups [NFC] (#182656)
I was reading through ObjectContainerBSDArchive and came across some dead method decls, a less-than-completely-clear `shared_ptr` typedef in `ObjectContainerBSDArchive::Archive` for a shared_ptr<Archive> which was a little unclear when reading a decl like `shared_ptr archive_sp;` for a local variable.
This commit is contained in:
1 parent
6654737d9a
commit
3f024d0835
6 files changed
+38
-42
No files matched your search
@@ -1203,9 +1203,7 @@ ObjectFile *Module::GetObjectFile() {
|
||||
m_did_load_objfile = true;
|
||||
// FindPlugin will modify its extractor_sp argument. Do not let it
|
||||
// modify our m_extractor_sp member.
|
||||
DataExtractorSP extractor_sp;
|
||||
if (m_extractor_sp)
|
||||
extractor_sp = m_extractor_sp;
|
||||
DataExtractorSP extractor_sp = m_extractor_sp;
|
||||
m_objfile_sp = ObjectFile::FindPlugin(
|
||||
shared_from_this(), &m_file, m_object_offset,
|
||||
file_size - m_object_offset, extractor_sp, data_offset);
|
||||
|
||||
Reference in new issue
Block a user