[lldb] Remove the global platform list
This patch moves the platform creation and selection logic into the per-debugger platform lists. I've tried to keep functional changes to a minimum -- the main (only) observable difference in this change is that APIs, which select a platform by name (e.g., Debugger::SetCurrentPlatform) will not automatically pick up a platform associated with another debugger (or no debugger at all). I've also added several tests for this functionality -- one of the pleasant consequences of the debugger isolation is that it is now possible to test the platform selection and creation logic. This is a product of the discussion at <https://discourse.llvm.org/t/multiple-platforms-with-the-same-name/59594>. Differential Revision: https://reviews.llvm.org/D120810
This commit is contained in:
1 parent
ba4537b227
commit
af921006d3
20 files changed
+388
-345
No files matched your search
@@ -92,3 +92,55 @@ class DebuggerAPITestCase(TestBase):
|
||||
|
||||
# Test the local property again, is it set to new_cache_line_size?
|
||||
self.assertEqual(get_cache_line_size(), new_cache_line_size)
|
||||
|
||||
def test_CreateTarget_platform(self):
|
||||
exe = self.getBuildArtifact("a.out")
|
||||
self.yaml2obj("elf.yaml", exe)
|
||||
error = lldb.SBError()
|
||||
target1 = self.dbg.CreateTarget(exe, None, "remote-linux",
|
||||
False, error)
|
||||
self.assertSuccess(error)
|
||||
platform1 = target1.GetPlatform()
|
||||
platform1.SetWorkingDirectory("/foo/bar")
|
||||
|
||||
# Reuse a platform if it matches the currently selected one...
|
||||
target2 = self.dbg.CreateTarget(exe, None, "remote-linux",
|
||||
False, error)
|
||||
self.assertSuccess(error)
|
||||
platform2 = target2.GetPlatform()
|
||||
self.assertEqual(platform2.GetWorkingDirectory(), "/foo/bar")
|
||||
|
||||
# ... but create a new one if it doesn't.
|
||||
self.dbg.SetSelectedPlatform(lldb.SBPlatform("remote-windows"))
|
||||
target3 = self.dbg.CreateTarget(exe, None, "remote-linux",
|
||||
False, error)
|
||||
self.assertSuccess(error)
|
||||
platform3 = target3.GetPlatform()
|
||||
self.assertIsNone(platform3.GetWorkingDirectory())
|
||||
|
||||
def test_CreateTarget_arch(self):
|
||||
exe = self.getBuildArtifact("a.out")
|
||||
if lldbplatformutil.getHostPlatform() == 'linux':
|
||||
self.yaml2obj("macho.yaml", exe)
|
||||
arch = "x86_64-apple-macosx"
|
||||
else:
|
||||
self.yaml2obj("elf.yaml", exe)
|
||||
arch = "x86_64-pc-linux"
|
||||
|
||||
fbsd = lldb.SBPlatform("remote-freebsd")
|
||||
self.dbg.SetSelectedPlatform(fbsd)
|
||||
|
||||
error = lldb.SBError()
|
||||
target1 = self.dbg.CreateTarget(exe, arch, None, False, error)
|
||||
self.assertSuccess(error)
|
||||
platform1 = target1.GetPlatform()
|
||||
self.assertEqual(platform1.GetName(), "remote-macosx")
|
||||
platform1.SetWorkingDirectory("/foo/bar")
|
||||
|
||||
# Reuse a platform even if it is not currently selected.
|
||||
self.dbg.SetSelectedPlatform(fbsd)
|
||||
target2 = self.dbg.CreateTarget(exe, arch, None, False, error)
|
||||
self.assertSuccess(error)
|
||||
platform2 = target2.GetPlatform()
|
||||
self.assertEqual(platform2.GetName(), "remote-macosx")
|
||||
self.assertEqual(platform2.GetWorkingDirectory(), "/foo/bar")
|
||||
Reference in new issue
Block a user