[mlir] Update method cast calls to function calls

The MLIR classes Type/Attribute/Operation/Op/Value support
cast/dyn_cast/isa/dyn_cast_or_null functionality through llvm's doCast
functionality in addition to defining methods with the same name.
This change begins the migration of uses of the method to the
corresponding function call as has been decided as more consistent.

Note that there still exist classes that only define methods directly,
such as AffineExpr, and this does not include work currently to support
a functional cast/isa call.

Context:

* https://mlir.llvm.org/deprecation/ at "Use the free function variants for dyn_cast/cast/isa/…"
* Original discussion at https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443

Implementation:
This follows a previous patch that updated calls
`op.cast<T>()-> cast<T>(op)`. However some cases could not handle an
unprefixed `cast` call due to occurrences of variables named cast, or
occurring inside of class definitions which would resolve to the method.
All C++ files that did not work automatically with `cast<T>()` are
updated here to `llvm::cast` and similar with the intention that they
can be easily updated after the methods are removed through a
find-replace.

See https://github.com/llvm/llvm-project/compare/main...tpopp:llvm-project:tidy-cast-check
for the clang-tidy check that is used and then update printed
occurrences of the function to include `llvm::` before.

One can then run the following:
```
ninja -C $BUILD_DIR clang-tidy

run-clang-tidy -clang-tidy-binary=$BUILD_DIR/bin/clang-tidy -checks='-*,misc-cast-functions'\
                 -export-fixes /tmp/cast/casts.yaml mlir/*\
                 -header-filter=mlir/ -fix

rm -rf $BUILD_DIR/tools/mlir/**/*.inc
```

Differential Revision: https://reviews.llvm.org/D150348
This commit is contained in:
Tres Popp committed 2023-05-12 11:21:30 +02:00
1 parent 5550c82189
commit c1fa60b4cd
96 files changed
+1888 -1780

No files matched your search

+2 -2
View File
@@ -16,7 +16,7 @@ MLIR_DEFINE_CAPI_DIALECT_REGISTRATION(PythonTest, python_test,
python_test::PythonTestDialect)
bool mlirAttributeIsAPythonTestTestAttribute(MlirAttribute attr) {
return unwrap(attr).isa<python_test::TestAttrAttr>();
return llvm::isa<python_test::TestAttrAttr>(unwrap(attr));
}
MlirAttribute mlirPythonTestTestAttributeGet(MlirContext context) {
@@ -24,7 +24,7 @@ MlirAttribute mlirPythonTestTestAttributeGet(MlirContext context) {
}
bool mlirTypeIsAPythonTestTestType(MlirType type) {
return unwrap(type).isa<python_test::TestTypeType>();
return llvm::isa<python_test::TestTypeType>(unwrap(type));
}
MlirType mlirPythonTestTestTypeGet(MlirContext context) {