[lldb] Fix a 32 bit warning in ScriptedProcessInterface
../llvm-project/lldb/include/lldb/Interpreter/ScriptedProcessInterface.h:61:12: warning: implicit conversion from 'unsigned long long' to 'size_t' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion] ../llvm-project/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:275:39: warning: result of comparison of constant 18446744073709551615 with expression of type 'size_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare] This happens because size_t on 32 bit is 32 bit, but LLDB_INVALID_OFFSET is UINT64_MAX. Return lldb::offset_t instead, which is 64 bit everywhere. DoWriteMemory still returns size_t but this is because every other Process derived thing does that. As long as the failure check works I think it should be fine. Reviewed By: mib Differential Revision: https://reviews.llvm.org/D146124
This commit is contained in:
1 parent
68685a7f6a
commit
e73dd6254e
4 files changed
+8
-7
No files matched your search
@@ -136,7 +136,7 @@ lldb::DataExtractorSP ScriptedProcessPythonInterface::ReadMemoryAtAddress(
|
||||
return data_sp;
|
||||
}
|
||||
|
||||
size_t ScriptedProcessPythonInterface::WriteMemoryAtAddress(
|
||||
lldb::offset_t ScriptedProcessPythonInterface::WriteMemoryAtAddress(
|
||||
lldb::addr_t addr, lldb::DataExtractorSP data_sp, Status &error) {
|
||||
Status py_error;
|
||||
StructuredData::ObjectSP obj =
|
||||
|
||||
Reference in new issue
Block a user