Alexandros Lamprineas
131ac51ab2
#195272 added a reference to opts::Hugify from LongJmp.cpp. This broke shared-library builds because LLVMBOLTPasses does not link against LLVMBOLTRuntimeLibs, where the option was previously defined. Move the opts::Hugify definition to CommandLineOpts.cpp, alongside the other global BOLT command-line options. This keeps the option available to LLVMBOLTPasses through its existing LLVMBOLTUtils dependency without adding a dependency on the runtime library layer.
72 lines
2.4 KiB
C++
72 lines
2.4 KiB
C++
//===- bolt/RuntimeLibs/HugifyRuntimeLibrary.cpp - Hugify RT Library ------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements the HugifyRuntimeLibrary class.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "bolt/RuntimeLibs/HugifyRuntimeLibrary.h"
|
|
#include "bolt/Core/BinaryContext.h"
|
|
#include "bolt/Core/Linker.h"
|
|
#include "llvm/MC/MCStreamer.h"
|
|
#include "llvm/Support/CommandLine.h"
|
|
|
|
using namespace llvm;
|
|
using namespace bolt;
|
|
|
|
namespace opts {
|
|
|
|
extern cl::OptionCategory BoltOptCategory;
|
|
|
|
extern cl::opt<bool> HotText;
|
|
|
|
static cl::opt<std::string>
|
|
RuntimeHugifyLib("runtime-hugify-lib",
|
|
cl::desc("specify path of the runtime hugify library"),
|
|
cl::init("libbolt_rt_hugify.a"), cl::cat(BoltOptCategory));
|
|
|
|
} // namespace opts
|
|
|
|
void HugifyRuntimeLibrary::adjustCommandLineOptions(
|
|
const BinaryContext &BC) const {
|
|
if (opts::HotText) {
|
|
errs()
|
|
<< "BOLT-ERROR: -hot-text should be applied to binaries with "
|
|
"pre-compiled manual hugify support, while -hugify will add hugify "
|
|
"support automatically. These two options cannot both be present.\n";
|
|
exit(1);
|
|
}
|
|
// After the check, we set HotText to be true because automated hugify support
|
|
// relies on it.
|
|
opts::HotText = true;
|
|
if (!BC.StartFunctionAddress) {
|
|
errs() << "BOLT-ERROR: hugify runtime libraries require a known entry "
|
|
"point of "
|
|
"the input binary\n";
|
|
exit(1);
|
|
}
|
|
}
|
|
|
|
void HugifyRuntimeLibrary::link(BinaryContext &BC, StringRef ToolPath,
|
|
BOLTLinker &Linker,
|
|
BOLTLinker::SectionsMapper MapSections) {
|
|
|
|
std::string LibPath = getLibPath(ToolPath, opts::RuntimeHugifyLib);
|
|
loadLibrary(LibPath, Linker, MapSections);
|
|
|
|
assert(!RuntimeStartAddress &&
|
|
"We don't currently support linking multiple runtime libraries");
|
|
auto StartSymInfo = Linker.lookupSymbolInfo("__bolt_hugify_self");
|
|
if (!StartSymInfo) {
|
|
errs() << "BOLT-ERROR: hugify library does not define __bolt_hugify_self: "
|
|
<< LibPath << "\n";
|
|
exit(1);
|
|
}
|
|
RuntimeStartAddress = StartSymInfo->Address;
|
|
}
|