As part of an attempt to streamline DebugLoc coverage/origin tracking using debugify, this patch adds a command-line flag that is used to explicitly enable origin-tracking, instead of being always-enabled if built with the feature. This flag also allows us to specify a list of passes to enable origin-tracking for, instead of having it enabled across all passes. Disabling origin-tracking still incurs the cost of storing a SmallVector with small size=0 (i.e. 3*sizeof(void*)) in each DebugLoc, but avoids the tremendous cost of collecting stacktraces at every empty DebugLoc construction - which occurs very frequently even in builds without missing coverage. The motivation for adding this flag is that it allows a Clang built with origin-tracking enabled to still be used in coverage-tracking mode with a relatively low cost; since origin-tracking only adds details to the errors that coverage-tracking detects, this allows a workflow where we use Clang with coverage-tracking enabled for all compile commands in a project, and for any compiles that detect missing coverage, the command is re-run with origin-tracking enabled for all the passes where missing locations were detected. This ensures we only pay for the very costly origin-tracking step when it is actually used, making origin-tracking more efficient in CI and practical in local builds.
210 lines
6.6 KiB
C++
210 lines
6.6 KiB
C++
//===-- DebugLoc.cpp - Implement DebugLoc class ---------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/IR/DebugLoc.h"
|
|
#include "llvm/Config/llvm-config.h"
|
|
#include "llvm/IR/DebugInfo.h"
|
|
|
|
using namespace llvm;
|
|
|
|
#if LLVM_ENABLE_DEBUGLOC_TRACKING_ORIGIN
|
|
#include "llvm/Support/Signals.h"
|
|
namespace llvm {
|
|
bool DebugLocOriginCollectionEnabled = false;
|
|
} // namespace llvm
|
|
|
|
DbgLocOrigin::DbgLocOrigin(bool ShouldCollectTrace) {
|
|
if (!ShouldCollectTrace || !DebugLocOriginCollectionEnabled)
|
|
return;
|
|
auto &[Depth, StackTrace] = StackTraces.emplace_back();
|
|
Depth = sys::getStackTrace(StackTrace);
|
|
}
|
|
void DbgLocOrigin::addTrace() {
|
|
// We only want to add new stacktraces if we already have one: addTrace exists
|
|
// to provide more context to how missing DebugLocs have propagated through
|
|
// the program, but by design if there is no existing stacktrace then we have
|
|
// decided not to track this DebugLoc as being "missing".
|
|
if (StackTraces.empty())
|
|
return;
|
|
auto &[Depth, StackTrace] = StackTraces.emplace_back();
|
|
Depth = sys::getStackTrace(StackTrace);
|
|
}
|
|
#endif // LLVM_ENABLE_DEBUGLOC_TRACKING_ORIGIN
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// DebugLoc Implementation
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
unsigned DebugLoc::getLine() const {
|
|
assert(get() && "Expected valid DebugLoc");
|
|
return get()->getLine();
|
|
}
|
|
|
|
unsigned DebugLoc::getCol() const {
|
|
assert(get() && "Expected valid DebugLoc");
|
|
return get()->getColumn();
|
|
}
|
|
|
|
MDNode *DebugLoc::getScope() const {
|
|
assert(get() && "Expected valid DebugLoc");
|
|
return get()->getScope();
|
|
}
|
|
|
|
DILocation *DebugLoc::getInlinedAt() const {
|
|
assert(get() && "Expected valid DebugLoc");
|
|
return get()->getInlinedAt();
|
|
}
|
|
|
|
MDNode *DebugLoc::getInlinedAtScope() const {
|
|
return cast<DILocation>(Loc)->getInlinedAtScope();
|
|
}
|
|
|
|
DebugLoc DebugLoc::getFnDebugLoc() const {
|
|
// FIXME: Add a method on \a DILocation that does this work.
|
|
const MDNode *Scope = getInlinedAtScope();
|
|
if (auto *SP = getDISubprogram(Scope))
|
|
return DILocation::get(SP->getContext(), SP->getScopeLine(), 0, SP);
|
|
|
|
return DebugLoc();
|
|
}
|
|
|
|
MDNode *DebugLoc::getAsMDNode() const { return Loc; }
|
|
|
|
bool DebugLoc::isImplicitCode() const {
|
|
if (DILocation *Loc = get())
|
|
return Loc->isImplicitCode();
|
|
return true;
|
|
}
|
|
|
|
void DebugLoc::setImplicitCode(bool ImplicitCode) {
|
|
if (DILocation *Loc = get())
|
|
Loc->setImplicitCode(ImplicitCode);
|
|
}
|
|
|
|
DebugLoc DebugLoc::replaceInlinedAtSubprogram(
|
|
const DebugLoc &RootLoc, DISubprogram &NewSP, LLVMContext &Ctx,
|
|
DenseMap<const MDNode *, MDNode *> &Cache) {
|
|
SmallVector<DILocation *> LocChain;
|
|
DILocation *CachedResult = nullptr;
|
|
|
|
// Collect the inline chain, stopping if we find a location that has already
|
|
// been processed.
|
|
for (DILocation *Loc = RootLoc; Loc; Loc = Loc->getInlinedAt()) {
|
|
if (auto It = Cache.find(Loc); It != Cache.end()) {
|
|
CachedResult = cast<DILocation>(It->second);
|
|
break;
|
|
}
|
|
LocChain.push_back(Loc);
|
|
}
|
|
|
|
DILocation *UpdatedLoc = CachedResult;
|
|
if (!UpdatedLoc) {
|
|
// If no cache hits, then back() is the end of the inline chain, that is,
|
|
// the DILocation whose scope ends in the Subprogram to be replaced.
|
|
DILocation *LocToUpdate = LocChain.pop_back_val();
|
|
DIScope *NewScope = DILocalScope::cloneScopeForSubprogram(
|
|
*LocToUpdate->getScope(), NewSP, Ctx, Cache);
|
|
UpdatedLoc = DILocation::get(Ctx, LocToUpdate->getLine(),
|
|
LocToUpdate->getColumn(), NewScope);
|
|
Cache[LocToUpdate] = UpdatedLoc;
|
|
}
|
|
|
|
// Recreate the location chain, bottom-up, starting at the new scope (or a
|
|
// cached result).
|
|
for (const DILocation *LocToUpdate : reverse(LocChain)) {
|
|
UpdatedLoc =
|
|
DILocation::get(Ctx, LocToUpdate->getLine(), LocToUpdate->getColumn(),
|
|
LocToUpdate->getScope(), UpdatedLoc);
|
|
Cache[LocToUpdate] = UpdatedLoc;
|
|
}
|
|
|
|
return UpdatedLoc;
|
|
}
|
|
|
|
DebugLoc DebugLoc::appendInlinedAt(const DebugLoc &DL, DILocation *InlinedAt,
|
|
LLVMContext &Ctx,
|
|
DenseMap<const MDNode *, MDNode *> &Cache) {
|
|
SmallVector<DILocation *, 3> InlinedAtLocations;
|
|
DILocation *Last = InlinedAt;
|
|
DILocation *CurInlinedAt = DL;
|
|
|
|
// Gather all the inlined-at nodes.
|
|
while (DILocation *IA = CurInlinedAt->getInlinedAt()) {
|
|
// Skip any we've already built nodes for.
|
|
if (auto *Found = Cache[IA]) {
|
|
Last = cast<DILocation>(Found);
|
|
break;
|
|
}
|
|
|
|
InlinedAtLocations.push_back(IA);
|
|
CurInlinedAt = IA;
|
|
}
|
|
|
|
// Starting from the top, rebuild the nodes to point to the new inlined-at
|
|
// location (then rebuilding the rest of the chain behind it) and update the
|
|
// map of already-constructed inlined-at nodes.
|
|
// Key Instructions: InlinedAt fields don't need atom info.
|
|
for (const DILocation *MD : reverse(InlinedAtLocations))
|
|
Cache[MD] = Last = DILocation::getDistinct(
|
|
Ctx, MD->getLine(), MD->getColumn(), MD->getScope(), Last);
|
|
|
|
return Last;
|
|
}
|
|
|
|
DebugLoc DebugLoc::getMergedLocations(ArrayRef<DebugLoc> Locs) {
|
|
if (Locs.empty())
|
|
return DebugLoc();
|
|
if (Locs.size() == 1)
|
|
return Locs[0];
|
|
DebugLoc Merged = Locs[0];
|
|
for (const DebugLoc &DL : llvm::drop_begin(Locs)) {
|
|
Merged = getMergedLocation(Merged, DL);
|
|
if (!Merged)
|
|
break;
|
|
}
|
|
return Merged;
|
|
}
|
|
DebugLoc DebugLoc::getMergedLocation(DebugLoc LocA, DebugLoc LocB) {
|
|
if (!LocA || !LocB) {
|
|
// If coverage tracking is enabled, prioritize returning empty non-annotated
|
|
// locations to empty annotated locations.
|
|
#if LLVM_ENABLE_DEBUGLOC_TRACKING_COVERAGE
|
|
if (!LocA && LocA.getKind() == DebugLocKind::Normal)
|
|
return LocA;
|
|
if (!LocB && LocB.getKind() == DebugLocKind::Normal)
|
|
return LocB;
|
|
#endif // LLVM_ENABLE_DEBUGLOC_TRACKING_COVERAGE
|
|
if (!LocA)
|
|
return LocA;
|
|
return LocB;
|
|
}
|
|
return DILocation::getMergedLocation(LocA, LocB);
|
|
}
|
|
|
|
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
|
|
LLVM_DUMP_METHOD void DebugLoc::dump() const { print(dbgs()); }
|
|
#endif
|
|
|
|
void DebugLoc::print(raw_ostream &OS) const {
|
|
if (!Loc)
|
|
return;
|
|
|
|
// Print source line info.
|
|
auto *Scope = cast<DIScope>(getScope());
|
|
OS << Scope->getFilename();
|
|
OS << ':' << getLine();
|
|
if (getCol() != 0)
|
|
OS << ':' << getCol();
|
|
|
|
if (DebugLoc InlinedAtDL = getInlinedAt()) {
|
|
OS << " @[ ";
|
|
InlinedAtDL.print(OS);
|
|
OS << " ]";
|
|
}
|
|
}
|