Med Ismail Bennani
1b4a578a9f
Replace the (class_name, args_sp) parameter pair on CreatePluginObject across the scripted plugin interfaces (ScriptedThread, OperatingSystem, ScriptedBreakpoint, ScriptedFrameProvider, ScriptedProcess, and the underlying ScriptedPythonInterface template) with a single `const ScriptedMetadata &`. Callers (OperatingSystemPython, ScriptedThread, ScriptedProcess, BreakpointResolverScripted, ScriptedFrameProvider) pass their existing ScriptedMetadata directly, removing the need to re-bundle class_name and args at every call site. ScriptedBreakpoint, ScriptedFrameProvider and ScriptedProcess no longer carry a redundant `args_sp` parameter; their callers fold those args into the metadata, and the Python overrides reconstruct a StructuredDataImpl from the metadata's args dict for the dispatched call. ScriptedInterface gains an `m_scripted_metadata` member and a `GetScriptedMetadata()` accessor; ScriptedPythonInterface populates it when CreatePluginObject is invoked so subclasses can later report which script class is in play. Hook/StopHook/ThreadPlan public interfaces keep their existing `args_sp` parameter for now; subsequent commits consolidate that. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
68 lines
2.4 KiB
C++
68 lines
2.4 KiB
C++
//===-- ScriptedStopHookPythonInterface.cpp -------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../lldb-python.h"
|
|
|
|
#include "lldb/Core/PluginManager.h"
|
|
#include "lldb/Target/ExecutionContext.h"
|
|
#include "lldb/Utility/Log.h"
|
|
#include "lldb/lldb-enumerations.h"
|
|
|
|
#include "../SWIGPythonBridge.h"
|
|
#include "../ScriptInterpreterPythonImpl.h"
|
|
#include "ScriptedStopHookPythonInterface.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
using namespace lldb_private::python;
|
|
|
|
ScriptedStopHookPythonInterface::ScriptedStopHookPythonInterface(
|
|
ScriptInterpreterPythonImpl &interpreter)
|
|
: ScriptedStopHookInterface(), ScriptedPythonInterface(interpreter) {}
|
|
|
|
llvm::Expected<StructuredData::GenericSP>
|
|
ScriptedStopHookPythonInterface::CreatePluginObject(
|
|
const ScriptedMetadata &scripted_metadata, lldb::TargetSP target_sp,
|
|
const StructuredDataImpl &args_sp) {
|
|
return ScriptedPythonInterface::CreatePluginObject(scripted_metadata, nullptr,
|
|
target_sp, args_sp);
|
|
}
|
|
|
|
llvm::Expected<bool>
|
|
ScriptedStopHookPythonInterface::HandleStop(ExecutionContext &exe_ctx,
|
|
lldb::StreamSP& output_sp) {
|
|
ExecutionContextRefSP exe_ctx_ref_sp =
|
|
std::make_shared<ExecutionContextRef>(exe_ctx);
|
|
Status error;
|
|
StructuredData::ObjectSP obj = Dispatch("handle_stop", error, exe_ctx_ref_sp, output_sp);
|
|
|
|
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
|
|
error)) {
|
|
if (!obj)
|
|
return true;
|
|
return error.ToError();
|
|
}
|
|
|
|
return obj->GetBooleanValue();
|
|
}
|
|
|
|
|
|
void ScriptedStopHookPythonInterface::Initialize() {
|
|
const std::vector<llvm::StringRef> ci_usages = {
|
|
"target stop-hook add -P <script-name> [-k key -v value ...]"};
|
|
const std::vector<llvm::StringRef> api_usages = {};
|
|
PluginManager::RegisterPlugin(
|
|
GetPluginNameStatic(),
|
|
llvm::StringRef("Perform actions whenever the process stops, before control is returned to the user."),
|
|
CreateInstance, eScriptLanguagePython, {ci_usages, api_usages});
|
|
}
|
|
|
|
void ScriptedStopHookPythonInterface::Terminate() {
|
|
PluginManager::UnregisterPlugin(CreateInstance);
|
|
}
|