Med Ismail Bennani
e28ea20ce0
Give `frame recognizer add -l` a formal ScriptedStackFrameRecognizerInterface, matching the architecture already used by ScriptedProcess, ScriptedBreakpoint, etc.: a C++ interface header, a Python-backed implementation built on ScriptedPythonInterface's CreatePluginObject/Dispatch machinery, PluginManager registration, and a generatable Python ABC template (scripted_stackframe_recognizer.py). get_recognized_arguments' documented contract returns a plain list of lldb.SBValue (not an lldb.SBValueList), so it bypasses the generic Dispatch<ValueObjectListSP>() extractor and calls the SWIG bridge directly, matching the legacy behavior exactly. ScriptedStackFrameRecognizer now holds a single interface object created once in its constructor and reused across every RecognizeFrame() call, same lifecycle as before. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma> (cherry picked from commit a07b91d8243b8a8051dbbe5739eacc7942269c61)
98 lines
3.5 KiB
C++
98 lines
3.5 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../lldb-python.h"
|
|
|
|
#include "lldb/Core/PluginManager.h"
|
|
#include "lldb/Target/StackFrame.h"
|
|
#include "lldb/lldb-enumerations.h"
|
|
|
|
#include "../SWIGPythonBridge.h"
|
|
#include "../ScriptInterpreterPythonImpl.h"
|
|
#include "ScriptedStackFrameRecognizerPythonInterface.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
using namespace lldb_private::python;
|
|
|
|
ScriptedStackFrameRecognizerPythonInterface::
|
|
ScriptedStackFrameRecognizerPythonInterface(
|
|
ScriptInterpreterPythonImpl &interpreter)
|
|
: ScriptedStackFrameRecognizerInterface(),
|
|
ScriptedPythonInterface(interpreter) {}
|
|
|
|
llvm::Expected<StructuredData::GenericSP>
|
|
ScriptedStackFrameRecognizerPythonInterface::CreatePluginObject(
|
|
const ScriptedMetadata &scripted_metadata) {
|
|
return ScriptedPythonInterface::CreatePluginObject(scripted_metadata,
|
|
nullptr);
|
|
}
|
|
|
|
lldb::ValueObjectListSP
|
|
ScriptedStackFrameRecognizerPythonInterface::GetRecognizedArguments(
|
|
lldb::StackFrameSP frame_sp) {
|
|
Status error;
|
|
return Dispatch<lldb::ValueObjectListSP>("get_recognized_arguments", error,
|
|
frame_sp);
|
|
}
|
|
|
|
bool ScriptedStackFrameRecognizerPythonInterface::ShouldHide(
|
|
lldb::StackFrameSP frame_sp) {
|
|
Status error;
|
|
StructuredData::ObjectSP obj = Dispatch("should_hide", error, frame_sp);
|
|
|
|
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
|
|
error))
|
|
return false;
|
|
|
|
return obj->GetBooleanValue();
|
|
}
|
|
|
|
lldb::StackFrameSP
|
|
ScriptedStackFrameRecognizerPythonInterface::SelectMostRelevantFrame(
|
|
lldb::StackFrameSP frame_sp) {
|
|
Status error;
|
|
return Dispatch<lldb::StackFrameSP>("select_most_relevant_frame", error,
|
|
frame_sp);
|
|
}
|
|
|
|
lldb::ValueObjectSP ScriptedStackFrameRecognizerPythonInterface::GetException(
|
|
lldb::StackFrameSP frame_sp) {
|
|
Status error;
|
|
return Dispatch<lldb::ValueObjectSP>("get_exception", error, frame_sp);
|
|
}
|
|
|
|
std::string ScriptedStackFrameRecognizerPythonInterface::GetStopDescription(
|
|
lldb::StackFrameSP frame_sp) {
|
|
Status error;
|
|
StructuredData::ObjectSP obj =
|
|
Dispatch("get_stop_description", error, frame_sp);
|
|
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
|
|
error))
|
|
return "";
|
|
return obj->GetStringValue().str();
|
|
}
|
|
|
|
void ScriptedStackFrameRecognizerPythonInterface::Initialize() {
|
|
const std::vector<llvm::StringRef> ci_usages = {
|
|
"frame recognizer add -l <script-name> [-s <shlib> ...] "
|
|
"[-n <symbol> ... | -x <symbol-regex>] [-f false] "
|
|
"[--mangled-name-preference <mode>]"};
|
|
PluginManager::RegisterPlugin(
|
|
GetPluginNameStatic(),
|
|
"Recognize a stack frame and provide extra information about it "
|
|
"(recognized arguments, exception object, stop description, "
|
|
"hidden/most-relevant frame).",
|
|
CreateInstance, eScriptedExtensionScriptedStackFrameRecognizer,
|
|
eScriptLanguagePython, {ci_usages, {}});
|
|
}
|
|
|
|
void ScriptedStackFrameRecognizerPythonInterface::Terminate() {
|
|
PluginManager::UnregisterPlugin(CreateInstance);
|
|
}
|