According to section 7.24.1 of the C standard, character comparison in string functions must be performed as if the characters had the type `unsigned char`. The previous implementations of `strcmp`, `strncmp`, and `strcoll` were doing a direct subtraction of `char` values. On platforms where `char` is signed, this resulted in incorrect negative values being returned when characters exceeding 127 were being compared. This patch fixes the comparison functions to explicitly cast the character values to `unsigned char` prior to computing their difference. It also adds regression tests to ensure the comparison behaves correctly for ASCII values greater than 127.
27 lines
905 B
C++
27 lines
905 B
C++
//===-- Implementation of strcoll -----------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "src/string/strcoll.h"
|
|
|
|
#include "src/__support/common.h"
|
|
#include "src/__support/macros/config.h"
|
|
#include "src/__support/macros/null_check.h"
|
|
|
|
namespace LIBC_NAMESPACE_DECL {
|
|
|
|
// TODO: Add support for locales.
|
|
LLVM_LIBC_FUNCTION(int, strcoll, (const char *left, const char *right)) {
|
|
LIBC_CRASH_ON_NULLPTR(left);
|
|
LIBC_CRASH_ON_NULLPTR(right);
|
|
for (; *left && *left == *right; ++left, ++right)
|
|
;
|
|
return static_cast<unsigned char>(*left) - static_cast<unsigned char>(*right);
|
|
}
|
|
|
|
} // namespace LIBC_NAMESPACE_DECL
|