qi-hardware/gmenu2x
1
0
Fork 0
mirror of git://projects.qi-hardware.com/gmenu2x.git synced 2025-04-21 12:27:27 +03:00
Code Activity

Put Surface argument first in Dialog paint methods

Browse Source 
This is the convention that most classes stick to. The likely reason
why Dialog didn't stick to the convention was to be able to provide
a default value for this argument, but that feature wasn't very useful
since every caller already had access to the default surface.
This commit is contained in:
Maarten ter Huurne
2014-08-10 04:02:10 +02:00
parent 5a281cf661
commit 20c5ec4eb6
9 changed files with 29 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/settingsdialog.cpp
View File

@@ -84,8 +84,8 @@ bool SettingsDialog::exec() {
gmenu2x->drawTopBar(gmenu2x->s);
//link icon
drawTitleIcon(icon);
writeTitle(text);
drawTitleIcon(gmenu2x->s, icon);
writeTitle(gmenu2x->s, text);
gmenu2x->drawBottomBar(gmenu2x->s);
@@ -119,7 +119,7 @@ bool SettingsDialog::exec() {
gmenu2x->drawScrollBar(numRows, voices.size(), firstElement);
//description
writeSubTitle(voices[sel]->getDescription());
writeSubTitle(gmenu2x->s, voices[sel]->getDescription());
gmenu2x->s->flip();
voices[sel]->handleTS(maxNameWidth + 15, iY, rowHeight);