qi-hardware/gmenu2x
1
0
Fork 0
mirror of git://projects.qi-hardware.com/gmenu2x.git synced 2025-04-21 12:27:27 +03:00
Code Activity

Remove unnecessary file existence check in GMenu2X::readConfig(string)

Browse Source 
A file existence check is already performed, atomically with respect to
the filesystem, by ifstream's constructor. The result of this check is
available using ifstream::is_open().
This commit is contained in:
Nebuleon Fumika
2014-08-10 22:23:57 +00:00
committed by Maarten ter Huurne
parent a741653a13
commit 457fb0a085
1 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/gmenu2x.cpp
View File

@@ -448,7 +448,6 @@ void GMenu2X::readConfig() {
} }
void GMenu2X::readConfig(string conffile) { void GMenu2X::readConfig(string conffile) {
if (fileExists(conffile)) {
ifstream inf(conffile.c_str(), ios_base::in); ifstream inf(conffile.c_str(), ios_base::in);
if (inf.is_open()) { if (inf.is_open()) {
string line; string line;
@@ -464,7 +463,7 @@ void GMenu2X::readConfig(string conffile) {
} }
inf.close(); inf.close();
} }
}
if (!confStr["lang"].empty()) if (!confStr["lang"].empty())
tr.setLang(confStr["lang"]); tr.setLang(confStr["lang"]);