Remove unnecessary file existence check in GMenu2X::writeSkinConfig

mkdir is able to return an error code in errno to indicate that the
directory requested to be created already exists (EEXIST).
This commit is contained in:
Nebuleon Fumika
2014-08-13 22:44:43 +02:00
committed by Maarten ter Huurne
parent 8cd3ab8cb8
commit a60a529de6
+8 -4
View File
@@ -508,11 +508,15 @@ void GMenu2X::writeConfig() {
void GMenu2X::writeSkinConfig() {
string conffile = getHome() + "/skins/";
if (!fileExists(conffile))
mkdir(conffile.c_str(), 0770);
if (mkdir(conffile.c_str(), 0770) < 0 && errno != EEXIST) {
ERROR("Failed to create directory %s to write skin configuration: %s\n", conffile.c_str(), strerror(errno));
return;
}
conffile = conffile + confStr["skin"];
if (!fileExists(conffile))
mkdir(conffile.c_str(), 0770);
if (mkdir(conffile.c_str(), 0770) < 0 && errno != EEXIST) {
ERROR("Failed to create directory %s to write skin configuration: %s\n", conffile.c_str(), strerror(errno));
return;
}
conffile = conffile + "/skin.conf";
ofstream inf(conffile.c_str());