From ac30153cfc0bc88d589ba9cec9983372d8b6c29a Mon Sep 17 00:00:00 2001 From: Maarten ter Huurne Date: Wed, 28 Jul 2010 00:38:47 +0200 Subject: [PATCH] Declared methods abstract where possible; moved destructor implementation out of header. Together this reduces the binary size by about 7.5K on mipsel. --- src/menusetting.cpp | 6 +++++- src/menusetting.h | 10 +++++----- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/menusetting.cpp b/src/menusetting.cpp index 4d589f4..e316368 100644 --- a/src/menusetting.cpp +++ b/src/menusetting.cpp @@ -28,6 +28,10 @@ MenuSetting::MenuSetting(GMenu2X *gmenu2x, const string &name, { } +MenuSetting::~MenuSetting() +{ +} + void MenuSetting::draw(int y) { gmenu2x->s->write( gmenu2x->font, name, 5, y+gmenu2x->font->getHalfHeight(), SFontHAlignLeft, SFontVAlignMiddle ); @@ -38,7 +42,7 @@ void MenuSetting::handleTS() buttonBox.handleTS(); } -void MenuSetting::drawSelected(int) +void MenuSetting::drawSelected(int /*y*/) { buttonBox.paint(5); } diff --git a/src/menusetting.h b/src/menusetting.h index da82db6..cb0effc 100644 --- a/src/menusetting.h +++ b/src/menusetting.h @@ -44,15 +44,15 @@ protected: public: MenuSetting(GMenu2X *gmenu2x, const string &name, const string &description); - virtual ~MenuSetting() {}; + virtual ~MenuSetting(); virtual void draw(int y); virtual void handleTS(); - virtual void manageInput() {}; - virtual void adjustInput() {}; - virtual void drawSelected(int); - virtual bool edited() { return true; }; + virtual void manageInput() = 0; + virtual void adjustInput() = 0; + virtual void drawSelected(int y); + virtual bool edited() = 0; const string &getDescription() { return description; } };