qi-hardware/gmenu2x
1
0
Fork 0
mirror of git://projects.qi-hardware.com/gmenu2x.git synced 2025-04-21 12:27:27 +03:00
Code Activity

Cap the width of setting names in SettingDialog to the width of the longest

Browse Source 
Setting values are now displayed 10 pixels to the right of setting names, as
passed to MenuSetting::draw.

This commit also contains the following cleanups:

* The height of a row is passed to MenuSetting's draw and touchscreen methods.
* MenuSettingRGBA's magic constant (36) to separate the text for a color's
  four components is now a named constant.
* MenuSettingRGBA's color preview squares are now rowHeight - 2 pixels tall,
  and have a white border surrounded by a black border to help view the color
  it contains in both light and dark themes.
* The rectangle behind the selected setting's name is now drawn by that
  setting's drawSelected method.
This commit is contained in:
Nebuleon Fumika
2014-07-24 06:08:54 +00:00
committed by Maarten ter Huurne
parent 15472a073e
commit bac622fc39
11 changed files with 53 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/settingsdialog.cpp
View File

@@ -72,6 +72,11 @@ bool SettingsDialog::exec() {
uint rowHeight = gmenu2x->font->getLineSpacing() + 1; // gp2x=15+1 / pandora=19+1
uint numRows = (gmenu2x->resY - topBarHeight - 20) / rowHeight;
uint maxNameWidth = 0;
for (auto it = voices.begin(); it != voices.end(); it++) {
maxNameWidth = max(maxNameWidth, (uint) gmenu2x->font->getTextWidth((*it)->getName()));
}
while (!close) {
if (ts.available()) ts.poll();
@@ -89,19 +94,10 @@ bool SettingsDialog::exec() {
//selection
uint iY = topBarHeight + 2 + (sel - firstElement) * rowHeight;
gmenu2x->s->setClipRect(clipRect);
if (sel<voices.size()) {
gmenu2x->s->box(
1, iY, 148, rowHeight - 2,
gmenu2x->skinConfColors[COLOR_SELECTION_BG]
);
}
gmenu2x->s->clearClipRect();
//selected option
voices[sel]->drawSelected(iY);
voices[sel]->drawSelected(maxNameWidth + 15, iY, rowHeight);
gmenu2x->s->setClipRect(clipRect);
if (ts_pressed && !ts.pressed()) {
ts_pressed = false;
}
@@ -110,7 +106,7 @@ bool SettingsDialog::exec() {
}
for (i=firstElement; i<voices.size() && i<firstElement+numRows; i++) {
iY = i-firstElement;
voices[i]->draw(iY * rowHeight + topBarHeight + 2);
voices[i]->draw(maxNameWidth + 15, iY * rowHeight + topBarHeight + 2, rowHeight);
if (ts.available() && ts.pressed() && ts.inRect(
touchRect.x, touchRect.y + (iY * rowHeight),
touchRect.w, rowHeight
@@ -119,7 +115,6 @@ bool SettingsDialog::exec() {
sel = i;
}
}
gmenu2x->s->clearClipRect();
gmenu2x->drawScrollBar(numRows, voices.size(), firstElement);
@@ -127,7 +122,7 @@ bool SettingsDialog::exec() {
writeSubTitle(voices[sel]->getDescription());
gmenu2x->s->flip();
voices[sel]->handleTS();
voices[sel]->handleTS(maxNameWidth + 15, iY, rowHeight);
InputManager::Button button = inputMgr.waitForPressedButton();
if (!voices[sel]->handleButtonPress(button)) {