mirror of
git://projects.qi-hardware.com/gmenu2x.git
synced 2024-11-22 06:39:41 +02:00
Make writeStringToFile resilient against short writes
There are various situations in which write() might write less than the requested amount. In that case, if any progress was made (more than 0 bytes written), try again, otherwise consider it an error. Thanks to Nebuleon for reviewing.
This commit is contained in:
parent
104d749513
commit
e12c896b99
@ -92,7 +92,19 @@ bool writeStringToFile(string const& filename, string const& data) {
|
||||
}
|
||||
|
||||
// Write temporary file.
|
||||
bool ok = write(fd, data.c_str(), data.size()) >= 0;
|
||||
const char *bytes = data.c_str();
|
||||
size_t remaining = data.size();
|
||||
bool ok = true;
|
||||
while (remaining != 0) {
|
||||
ssize_t written = write(fd, bytes, remaining);
|
||||
if (written <= 0) {
|
||||
ok = false;
|
||||
break;
|
||||
} else {
|
||||
bytes += written;
|
||||
remaining -= written;
|
||||
}
|
||||
}
|
||||
if (ok) {
|
||||
ok = fsync(fd) == 0;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user