mirror of
git://projects.qi-hardware.com/openwrt-xburst.git
synced 2024-11-30 04:21:33 +02:00
44 lines
1.3 KiB
Diff
44 lines
1.3 KiB
Diff
|
Subject: Bug#284382: ppp: linkpidfile is not created upon detachment
|
||
|
|
From: <herbert@gondor.apana.org.au>
|
||
|
|
|
||
|
|
Package: ppp
|
||
|
|
Version: 2.4.2+20040428-2
|
||
|
|
Severity: wishlist
|
||
|
|
|
||
|
|
When pppd detaches from the parent normally, that is, without nodetach
|
||
|
|
or updetach set, the linkpidfile is not created even when linkname is
|
||
|
|
set.
|
||
|
|
|
||
|
|
This is because the create_linkpidfile call in detach() is only made
|
||
|
|
if the linkpidfile is filled in. However, linkpidfile is never filled
|
||
|
|
in until create_linkpidfile has been called.
|
||
|
|
|
||
|
|
IMHO the call should be made uncondtionally in detach() since
|
||
|
|
create_linkpidfile does its own check on linkname anyway.
|
||
|
|
|
||
|
|
Please note that the version of pppd in woody always wrote the
|
||
|
|
linkpidfile after detaching. It did so in main() however. That
|
||
|
|
call has now been removed which is why I'm seeing this problem.
|
||
|
|
|
||
|
|
[...]
|
||
|
|
|
||
|
|
--
|
||
|
|
Index: pppd/main.c
|
||
|
|
===================================================================
|
||
|
|
RCS file: /var/cvs/snwb/packages/ppp/pppd/main.c,v
|
||
|
|
retrieving revision 1.11
|
||
|
|
diff -u -r1.11 main.c
|
||
|
|
--- ppp/pppd/main.c 29 Nov 2004 22:49:23 -0000 1.11
|
||
|
|
+++ ppp/pppd/main.c 5 Dec 2004 23:59:58 -0000
|
||
|
|
@@ -819,8 +819,7 @@
|
||
|
|
/* update pid files if they have been written already */
|
||
|
|
if (pidfilename[0])
|
||
|
|
create_pidfile(pid);
|
||
|
|
- if (linkpidfile[0])
|
||
|
|
- create_linkpidfile(pid);
|
||
|
|
+ create_linkpidfile(pid);
|
||
|
|
exit(0); /* parent dies */
|
||
|
|
}
|
||
|
|
setsid();
|
||
|
|
|