From 61cbda806f4198817dfd09e2f201c82948cbd544 Mon Sep 17 00:00:00 2001 From: jow Date: Sat, 7 Jul 2012 16:43:27 +0000 Subject: [PATCH] [package] uhttpd: do not dispatch pipe error events, fixes use after free for cgi and lua scripts git-svn-id: svn://svn.openwrt.org/openwrt/trunk@32644 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- package/uhttpd/src/uhttpd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/package/uhttpd/src/uhttpd.c b/package/uhttpd/src/uhttpd.c index 73f6e03bd..3237fbab5 100644 --- a/package/uhttpd/src/uhttpd.c +++ b/package/uhttpd/src/uhttpd.c @@ -573,9 +573,13 @@ static void uh_pipe_cb(struct uloop_fd *u, unsigned int events) { struct client *cl = container_of(u, struct client, pipe); - D("SRV: Client(%d) pipe(%d) readable\n", cl->fd.fd, cl->pipe.fd); + if (!u->error) + { + D("SRV: Client(%d) pipe(%d) readable\n", + cl->fd.fd, cl->pipe.fd); - uh_client_cb(&cl->fd, ULOOP_WRITE); + uh_client_cb(&cl->fd, ULOOP_WRITE); + } } static void uh_child_cb(struct uloop_process *p, int rv)