1
0
mirror of git://projects.qi-hardware.com/openwrt-xburst.git synced 2024-12-26 19:30:50 +02:00
Commit Graph

16 Commits

Author SHA1 Message Date
nbd
09fc3a65d9 Fix a memory leak in hotplug2 environment handling.
Bump hotplug2 to the latest svn revision, remove obsolete patches.

Memory leak is caused by the way hotplug2 handles environment variables,
using setenv() and unsetenv(). setenv() creates copies of the supplied
strings, but, due to a POSIX blunder, these copies are never destroyed
by unsetenv(), neither in glibc nor uclibc - not until the program
terminates.

Since some events are handled directly in the main process, even when
configured with the "fork" worker, hotplug2 memory usage will keep
growing over time. This can be observed by running "udevtrigger" and
noting the increase in hotplug2 VmRSS after each run.

This patch uses putenv() instead, which leaves storage management to
the caller, so that we can explicitly delete stuff when it's no longer
needed.

Signed-off-by: Aleksandar Radovanovic <biblbroks@sezampro.rs>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@18725 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-12-09 18:50:49 +00:00
nbd
de45c75915 hotplug2: get rid of the unnecessary reference to libdl as well
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@18106 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-10-20 20:59:40 +00:00
nbd
183ed59cff hotplug2: compile in the worker module statically, saves >20k uncompressed
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@18104 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-10-20 20:49:44 +00:00
nbd
5b12db1589 hotplug2: fix "MALLOC FAILURE!" message caused by a missing return code check on recv()
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@18061 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-10-19 02:39:02 +00:00
hcg
e78f0c2415 [hotplug2] Move hotplug2 v0.9 to hotplug2-old
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@16135 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-05-28 13:20:54 +00:00
blogic
1cc4a34061 remove warning from hotplug2, which pops up 10 times during boot
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@12086 3c298f89-4303-0410-b956-a3cf2f4a3e73
2008-08-04 08:04:16 +00:00
nbd
61bccd5e21 fix hotplug2 event processing deadlock
when bringing up ethernet on ixp4xx, the driver may request
a firmware while hotplug2 waits for the netdev bringup to complete.
change the event processing loop to keep an event backlog to allow
unthrottled events to pass through while throttled events are being waited for


git-svn-id: svn://svn.openwrt.org/openwrt/trunk@12019 3c298f89-4303-0410-b956-a3cf2f4a3e73
2008-07-30 19:02:01 +00:00
nbd
7fca59b786 fix two small bugs in the hotplug2 rule parser (#2085)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@8023 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-07-18 07:23:40 +00:00
nbd
af7fc344c8 hotplug2 update - include hotplug2-init.rules from hotplug2.rules, fix permissions of various devices (fixes #2052)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7892 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-07-09 00:13:47 +00:00
nbd
370c954b81 replace the hotplug2 fork handling hack with a better solution implemented in upstream (thanks, iSteve)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7786 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-30 11:05:14 +00:00
nbd
aa9d23c302 hotplug2: add fork handling optimization (also fixes that pesky pppoe race condition in #1655)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7726 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 09:47:58 +00:00
nbd
024945eed5 update to hotplug2 svn version (recommended by iSteve)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7725 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 09:46:37 +00:00
nbd
52242b5f8e hotplug2: add a missing cflag, allow hotplug events that are not 'add'
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7721 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 07:08:35 +00:00
nbd
1b9d91c491 make hotplug2 use the build system cflags
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7720 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 06:30:36 +00:00
nbd
b5cb1795de refresh all package patches in the buildroot using quilt
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7490 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-04 11:25:53 +00:00
nbd
2d6b53deec use hotplug2 for serializing hotplug events on 2.6
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7097 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-05-05 18:33:18 +00:00