mirror of
git://projects.qi-hardware.com/openwrt-xburst.git
synced 2024-11-09 09:32:50 +02:00
336fec3a5c
I discovered another bug in the ath9k WNDR3700 quirk fix from r23822. ath9k_hw_apply_gpio_override was testing the original value of gpio_mask to determine which bits were appropriate, instead of testing the shifted value. Because bit 0 is always clear in the original value, this resulted in no calls to set the GPIOs, an improperly-configured radio, and reduced RSSI on other systems listening to the radio. Signed-off-by: Mark Mentovai <mark@moxienet.com> git-svn-id: svn://svn.openwrt.org/openwrt/trunk@23890 3c298f89-4303-0410-b956-a3cf2f4a3e73
59 lines
1.5 KiB
Diff
59 lines
1.5 KiB
Diff
--- a/drivers/net/wireless/ath/ath9k/debug.c
|
|
+++ b/drivers/net/wireless/ath/ath9k/debug.c
|
|
@@ -920,6 +920,12 @@ int ath9k_init_debug(struct ath_hw *ah)
|
|
sc->debug.debugfs_phy, &ah->config.cwm_ignore_extcca))
|
|
goto err;
|
|
|
|
+ debugfs_create_u32("gpio_mask", S_IRUSR | S_IWUSR,
|
|
+ sc->debug.debugfs_phy, &sc->sc_ah->gpio_mask);
|
|
+
|
|
+ debugfs_create_u32("gpio_val", S_IRUSR | S_IWUSR,
|
|
+ sc->debug.debugfs_phy, &sc->sc_ah->gpio_val);
|
|
+
|
|
sc->debug.regidx = 0;
|
|
return 0;
|
|
err:
|
|
--- a/drivers/net/wireless/ath/ath9k/hw.h
|
|
+++ b/drivers/net/wireless/ath/ath9k/hw.h
|
|
@@ -743,6 +743,8 @@ struct ath_hw {
|
|
int initPDADC;
|
|
int PDADCdelta;
|
|
u8 led_pin;
|
|
+ u32 gpio_mask;
|
|
+ u32 gpio_val;
|
|
|
|
struct ar5416IniArray iniModes;
|
|
struct ar5416IniArray iniCommon;
|
|
--- a/drivers/net/wireless/ath/ath9k/hw.c
|
|
+++ b/drivers/net/wireless/ath/ath9k/hw.c
|
|
@@ -1178,6 +1178,20 @@ static bool ath9k_hw_channel_change(stru
|
|
return true;
|
|
}
|
|
|
|
+static void ath9k_hw_apply_gpio_override(struct ath_hw *ah)
|
|
+{
|
|
+ u32 gpio_mask = ah->gpio_mask;
|
|
+ int i;
|
|
+
|
|
+ for (i = 0; gpio_mask; i++, gpio_mask >>= 1) {
|
|
+ if (!(gpio_mask & 1))
|
|
+ continue;
|
|
+
|
|
+ ath9k_hw_cfg_output(ah, i, AR_GPIO_OUTPUT_MUX_AS_OUTPUT);
|
|
+ ath9k_hw_set_gpio(ah, i, !!(ah->gpio_val & BIT(i)));
|
|
+ }
|
|
+}
|
|
+
|
|
bool ath9k_hw_check_alive(struct ath_hw *ah)
|
|
{
|
|
int count = 50;
|
|
@@ -1464,6 +1478,8 @@ int ath9k_hw_reset(struct ath_hw *ah, st
|
|
if (AR_SREV_9300_20_OR_LATER(ah))
|
|
ar9003_hw_bb_watchdog_config(ah);
|
|
|
|
+ ath9k_hw_apply_gpio_override(ah);
|
|
+
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL(ath9k_hw_reset);
|