Files
llvm-tms34010/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedFramePythonInterface.cpp
T
Med Ismail Bennani 1b4a578a9f [lldb/Interpreter] Plumb ScriptedMetadata through scripted plugin CreatePluginObject (NFC) (#198425)
Replace the (class_name, args_sp) parameter pair on CreatePluginObject
across the scripted plugin interfaces (ScriptedThread, OperatingSystem,
ScriptedBreakpoint, ScriptedFrameProvider, ScriptedProcess, and the
underlying ScriptedPythonInterface template) with a single `const
ScriptedMetadata &`. Callers (OperatingSystemPython, ScriptedThread,
ScriptedProcess, BreakpointResolverScripted, ScriptedFrameProvider) pass
their existing ScriptedMetadata directly, removing the need to re-bundle
class_name and args at every call site.

ScriptedBreakpoint, ScriptedFrameProvider and ScriptedProcess no longer
carry a redundant `args_sp` parameter; their callers fold those args
into the metadata, and the Python overrides reconstruct a
StructuredDataImpl from the metadata's args dict for the dispatched
call.

ScriptedInterface gains an `m_scripted_metadata` member and a
`GetScriptedMetadata()` accessor; ScriptedPythonInterface populates it
when CreatePluginObject is invoked so subclasses can later report which
script class is in play.

Hook/StopHook/ThreadPlan public interfaces keep their existing `args_sp`
parameter for now; subsequent commits consolidate that.

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
2026-05-20 13:07:31 -07:00

181 lines
5.9 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "../lldb-python.h"
#include "lldb/Host/Config.h"
#include "lldb/Target/ExecutionContext.h"
#include "lldb/Utility/Log.h"
#include "lldb/lldb-enumerations.h"
#include "../SWIGPythonBridge.h"
#include "../ScriptInterpreterPythonImpl.h"
#include "ScriptedFramePythonInterface.h"
#include <optional>
using namespace lldb;
using namespace lldb_private;
using namespace lldb_private::python;
using Locker = ScriptInterpreterPythonImpl::Locker;
ScriptedFramePythonInterface::ScriptedFramePythonInterface(
ScriptInterpreterPythonImpl &interpreter)
: ScriptedFrameInterface(), ScriptedPythonInterface(interpreter) {}
llvm::Expected<StructuredData::GenericSP>
ScriptedFramePythonInterface::CreatePluginObject(
const llvm::StringRef class_name, ExecutionContext &exe_ctx,
StructuredData::DictionarySP args_sp, StructuredData::Generic *script_obj) {
ExecutionContextRefSP exe_ctx_ref_sp =
std::make_shared<ExecutionContextRef>(exe_ctx);
ScriptedMetadata scripted_metadata(class_name, args_sp);
return ScriptedPythonInterface::CreatePluginObject(
scripted_metadata, script_obj, exe_ctx_ref_sp, args_sp);
}
lldb::user_id_t ScriptedFramePythonInterface::GetID() {
Status error;
StructuredData::ObjectSP obj = Dispatch("get_id", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error))
return LLDB_INVALID_FRAME_ID;
return obj->GetUnsignedIntegerValue(LLDB_INVALID_FRAME_ID);
}
lldb::addr_t ScriptedFramePythonInterface::GetPC() {
Status error;
StructuredData::ObjectSP obj = Dispatch("get_pc", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error))
return LLDB_INVALID_ADDRESS;
return obj->GetUnsignedIntegerValue(LLDB_INVALID_ADDRESS);
}
std::optional<SymbolContext> ScriptedFramePythonInterface::GetSymbolContext() {
Status error;
auto sym_ctx = Dispatch<SymbolContext>("get_symbol_context", error);
if (error.Fail()) {
return ErrorWithMessage<SymbolContext>(LLVM_PRETTY_FUNCTION,
error.AsCString(), error);
}
return sym_ctx;
}
std::optional<std::string> ScriptedFramePythonInterface::GetFunctionName() {
Status error;
StructuredData::ObjectSP obj = Dispatch("get_function_name", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error))
return {};
return obj->GetStringValue().str();
}
std::optional<std::string>
ScriptedFramePythonInterface::GetDisplayFunctionName() {
Status error;
StructuredData::ObjectSP obj = Dispatch("get_display_function_name", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error))
return {};
return obj->GetStringValue().str();
}
bool ScriptedFramePythonInterface::IsInlined() {
Status error;
StructuredData::ObjectSP obj = Dispatch("is_inlined", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error))
return false;
return obj->GetBooleanValue();
}
bool ScriptedFramePythonInterface::IsArtificial() {
Status error;
StructuredData::ObjectSP obj = Dispatch("is_artificial", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error))
return false;
return obj->GetBooleanValue();
}
bool ScriptedFramePythonInterface::IsHidden() {
Status error;
StructuredData::ObjectSP obj = Dispatch("is_hidden", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error))
return false;
return obj->GetBooleanValue();
}
StructuredData::DictionarySP ScriptedFramePythonInterface::GetRegisterInfo() {
Status error;
StructuredData::DictionarySP dict =
Dispatch<StructuredData::DictionarySP>("get_register_info", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, dict,
error))
return {};
return dict;
}
std::optional<std::string> ScriptedFramePythonInterface::GetRegisterContext() {
Status error;
StructuredData::ObjectSP obj = Dispatch("get_register_context", error);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error))
return {};
return obj->GetAsString()->GetValue().str();
}
lldb::ValueObjectListSP ScriptedFramePythonInterface::GetVariables() {
Status error;
auto vals = Dispatch<lldb::ValueObjectListSP>("get_variables", error);
if (error.Fail()) {
return ErrorWithMessage<lldb::ValueObjectListSP>(LLVM_PRETTY_FUNCTION,
error.AsCString(), error);
}
return vals;
}
lldb::ValueObjectSP
ScriptedFramePythonInterface::GetValueObjectForVariableExpression(
llvm::StringRef expr, uint32_t options, Status &status) {
Status dispatch_error;
auto val = Dispatch<lldb::ValueObjectSP>("get_value_for_variable_expression",
dispatch_error, expr.data(), options,
status);
if (dispatch_error.Fail()) {
return ErrorWithMessage<lldb::ValueObjectSP>(
LLVM_PRETTY_FUNCTION, dispatch_error.AsCString(), dispatch_error);
}
return val;
}