Files
llvm-tms34010/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedHookPythonInterface.cpp
T
Charles Zablit 2384d2872b [lldb][windows] remove mandatory ordering of the lldb-python.h header (#197298)
`PosixApi.h` typedef'd `pid_t` as `uint32_t`, while Python's
`pyconfig.h` on Windows typedef's it as `int`. C++ forbids redeclaring a
typedef with a different type, so the two headers cannot coexist. The
`NO_PID_T` macro in `lldb-python.h` suppressed LLDB's typedef, but only
if `lldb-python.h` got included before `PosixApi.h`.

`pid_t` on Windows was originally defined in d87fc157d2. At this time,
there was no Python support for LLDB on Windows and `uint32_t` matches
the `DWORD` type used by the Win32 API for process IDs.

This patch matches the Python type in `PosixApi.h`, removing the need
for the include ordering.

This is a follow up to https://github.com/llvm/llvm-project/pull/197048.
2026-05-13 11:18:28 +02:00

107 lines
3.7 KiB
C++

//===-- ScriptedHookPythonInterface.cpp -----------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "../lldb-python.h"
#include "lldb/Core/PluginManager.h"
#include "lldb/Target/ExecutionContext.h"
#include "lldb/Utility/Log.h"
#include "lldb/lldb-enumerations.h"
#include "../SWIGPythonBridge.h"
#include "../ScriptInterpreterPythonImpl.h"
#include "ScriptedHookPythonInterface.h"
using namespace lldb;
using namespace lldb_private;
using namespace lldb_private::python;
ScriptedHookPythonInterface::ScriptedHookPythonInterface(
ScriptInterpreterPythonImpl &interpreter)
: ScriptedHookInterface(), ScriptedPythonInterface(interpreter) {}
ScriptedHookInterface::SupportedHookMethods
ScriptedHookPythonInterface::GetSupportedMethods() {
SupportedHookMethods methods;
// Qualify through ScriptedPythonInterface to resolve the diamond
// inheritance (both ScriptedHookInterface and ScriptedPythonInterface
// inherit ScriptedInterface which owns m_object_instance_sp).
auto &obj_sp = ScriptedPythonInterface::m_object_instance_sp;
if (!obj_sp)
return methods;
using Locker = ScriptInterpreterPythonImpl::Locker;
Locker py_lock(&m_interpreter, Locker::AcquireLock | Locker::NoSTDIN,
Locker::FreeLock);
PythonObject implementor(PyRefType::Borrowed, (PyObject *)obj_sp->GetValue());
if (!implementor.IsValid())
return methods;
methods.handle_module_loaded =
implementor.HasAttribute("handle_module_loaded");
methods.handle_module_unloaded =
implementor.HasAttribute("handle_module_unloaded");
methods.handle_stop = implementor.HasAttribute("handle_stop");
return methods;
}
llvm::Expected<StructuredData::GenericSP>
ScriptedHookPythonInterface::CreatePluginObject(
llvm::StringRef class_name, lldb::TargetSP target_sp,
const StructuredDataImpl &args_sp) {
return ScriptedPythonInterface::CreatePluginObject(class_name, nullptr,
target_sp, args_sp);
}
void ScriptedHookPythonInterface::HandleModuleLoaded(
lldb::StreamSP &output_sp) {
Status error;
Dispatch("handle_module_loaded", error, output_sp);
}
void ScriptedHookPythonInterface::HandleModuleUnloaded(
lldb::StreamSP &output_sp) {
Status error;
Dispatch("handle_module_unloaded", error, output_sp);
}
llvm::Expected<bool>
ScriptedHookPythonInterface::HandleStop(ExecutionContext &exe_ctx,
lldb::StreamSP &output_sp) {
ExecutionContextRefSP exe_ctx_ref_sp =
std::make_shared<ExecutionContextRef>(exe_ctx);
Status error;
StructuredData::ObjectSP obj =
Dispatch("handle_stop", error, exe_ctx_ref_sp, output_sp);
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
error)) {
if (!obj)
return true;
return error.ToError();
}
return obj->GetBooleanValue();
}
void ScriptedHookPythonInterface::Initialize() {
const std::vector<llvm::StringRef> ci_usages = {
"target hook add -P <script-name> [-k key -v value ...]"};
const std::vector<llvm::StringRef> api_usages = {};
PluginManager::RegisterPlugin(
GetPluginNameStatic(),
llvm::StringRef("Perform actions on target lifecycle events (module "
"load/unload, process stop)."),
CreateInstance, eScriptLanguagePython, {ci_usages, api_usages});
}
void ScriptedHookPythonInterface::Terminate() {
PluginManager::UnregisterPlugin(CreateInstance);
}