`PosixApi.h` typedef'd `pid_t` as `uint32_t`, while Python's
`pyconfig.h` on Windows typedef's it as `int`. C++ forbids redeclaring a
typedef with a different type, so the two headers cannot coexist. The
`NO_PID_T` macro in `lldb-python.h` suppressed LLDB's typedef, but only
if `lldb-python.h` got included before `PosixApi.h`.
`pid_t` on Windows was originally defined in d87fc157d2. At this time,
there was no Python support for LLDB on Windows and `uint32_t` matches
the `DWORD` type used by the Win32 API for process IDs.
This patch matches the Python type in `PosixApi.h`, removing the need
for the include ordering.
This is a follow up to https://github.com/llvm/llvm-project/pull/197048.
68 lines
2.5 KiB
C++
68 lines
2.5 KiB
C++
//===-- ScriptedStopHookPythonInterface.cpp -------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../lldb-python.h"
|
|
|
|
#include "lldb/Core/PluginManager.h"
|
|
#include "lldb/Target/ExecutionContext.h"
|
|
#include "lldb/Utility/Log.h"
|
|
#include "lldb/lldb-enumerations.h"
|
|
|
|
#include "../SWIGPythonBridge.h"
|
|
#include "../ScriptInterpreterPythonImpl.h"
|
|
#include "ScriptedStopHookPythonInterface.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
using namespace lldb_private::python;
|
|
|
|
ScriptedStopHookPythonInterface::ScriptedStopHookPythonInterface(
|
|
ScriptInterpreterPythonImpl &interpreter)
|
|
: ScriptedStopHookInterface(), ScriptedPythonInterface(interpreter) {}
|
|
|
|
llvm::Expected<StructuredData::GenericSP>
|
|
ScriptedStopHookPythonInterface::CreatePluginObject(llvm::StringRef class_name,
|
|
lldb::TargetSP target_sp,
|
|
const StructuredDataImpl &args_sp) {
|
|
return ScriptedPythonInterface::CreatePluginObject(class_name, nullptr,
|
|
target_sp, args_sp);
|
|
}
|
|
|
|
llvm::Expected<bool>
|
|
ScriptedStopHookPythonInterface::HandleStop(ExecutionContext &exe_ctx,
|
|
lldb::StreamSP& output_sp) {
|
|
ExecutionContextRefSP exe_ctx_ref_sp =
|
|
std::make_shared<ExecutionContextRef>(exe_ctx);
|
|
Status error;
|
|
StructuredData::ObjectSP obj = Dispatch("handle_stop", error, exe_ctx_ref_sp, output_sp);
|
|
|
|
if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
|
|
error)) {
|
|
if (!obj)
|
|
return true;
|
|
return error.ToError();
|
|
}
|
|
|
|
return obj->GetBooleanValue();
|
|
}
|
|
|
|
|
|
void ScriptedStopHookPythonInterface::Initialize() {
|
|
const std::vector<llvm::StringRef> ci_usages = {
|
|
"target stop-hook add -P <script-name> [-k key -v value ...]"};
|
|
const std::vector<llvm::StringRef> api_usages = {};
|
|
PluginManager::RegisterPlugin(
|
|
GetPluginNameStatic(),
|
|
llvm::StringRef("Perform actions whenever the process stops, before control is returned to the user."),
|
|
CreateInstance, eScriptLanguagePython, {ci_usages, api_usages});
|
|
}
|
|
|
|
void ScriptedStopHookPythonInterface::Terminate() {
|
|
PluginManager::UnregisterPlugin(CreateInstance);
|
|
}
|