qi-hardware/eda-tools
1
0
Fork 0
mirror of git://projects.qi-hardware.com/eda-tools.git synced 2024-11-29 11:56:15 +02:00
Code

eeshow/gfx/diff.c (merge_coord): typo caused offset troubles

Browse Source
This commit is contained in:
Werner Almesberger 2016-08-19 19:14:49 -03:00
parent 1805118940
commit 6be9e7ac0c
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
eeshow/TODO
View File

@ -37,6 +37,8 @@ Rendering:
- return indication of whether diff found any differences - return indication of whether diff found any differences
- in diff, pass only options understood by cairo_png - in diff, pass only options understood by cairo_png
- find out why in Cairo PDF non-dashed lines disappear if CAIRO_LINE_CAP_ROUND - find out why in Cairo PDF non-dashed lines disappear if CAIRO_LINE_CAP_ROUND
- non-interactive diff mode currently requires both sheets to have identical
size
GUI: GUI:
- fonts grow beyond their bounding boxes when zooming in - fonts grow beyond their bounding boxes when zooming in
@ -67,7 +69,3 @@ GUI/glabels:
- maybe indicate how it is used - maybe indicate how it is used
- there can be "hanging" pop-ups, see comment in gui/glabel.c:hover_glabel - there can be "hanging" pop-ups, see comment in gui/glabel.c:hover_glabel
- should there be a way to remove glabel highlighting ? - should there be a way to remove glabel highlighting ?
- comparing Neo900 fbc3a95 and 6a9f71a, sheet 2 has large offset differences,
causing hover to have displaced AoIs in diff_old, and both AoIs and overlays
are wrong in diff_new. Offset differences also defeat rapid switching between
old and new as a means to spot differences.

2
eeshow/gfx/diff.c
View File

@ -309,7 +309,7 @@ static void merge_coord(int pos_a, int pos_b, int dim_a, int dim_b,
*pos_res = pos_a; *pos_res = pos_a;
dim_b += pos_b - pos_a; dim_b += pos_b - pos_a;
} else { } else {
*pos_res = pos_a; *pos_res = pos_b;
dim_a += pos_a - pos_b; dim_a += pos_a - pos_b;
} }
*res_dim = dim_a > dim_b ? dim_a : dim_b; *res_dim = dim_a > dim_b ? dim_a : dim_b;