qi-hardware/eda-tools
1
0
Fork 0
mirror of git://projects.qi-hardware.com/eda-tools.git synced 2024-11-23 06:02:48 +02:00
Code

eeshow/diff.c (diff_to_canvas): point out flaw in offset calculation

Browse Source
This commit is contained in:
Werner Almesberger 2016-08-09 10:20:46 -03:00
parent 4988736351
commit 71e79a20d0
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
eeshow/diff.c
View File

@ -323,6 +323,12 @@ void diff_to_canvas(cairo_t *cr, int cx, int cy, float scale,
merge_coord(old_xmin, new_xmin, old_w, new_w, &xmin, &w); merge_coord(old_xmin, new_xmin, old_w, new_w, &xmin, &w);
merge_coord(old_ymin, new_ymin, old_h, new_h, &ymin, &h); merge_coord(old_ymin, new_ymin, old_h, new_h, &ymin, &h);
/*
* @@@ we should handle offset differences (xmin - old_xmin, et al.)
* before scaling. Else we risk rounding differences to lead to
* single-pixel differences, which the differences algorithm will
* be eager to mark with big yellow boxes.
*/
img_old = cro_img(old, img_old = cro_img(old,
-scale * cx + sw / 2.0 - (xmin - old_xmin) * scale, -scale * cx + sw / 2.0 - (xmin - old_xmin) * scale,
-scale * cy + sh / 2.0 - (ymin - old_ymin) * scale, -scale * cy + sh / 2.0 - (ymin - old_ymin) * scale,